Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @chunyong-lin
cc: @airbnb/binaryalert-maintainers
size: medium
Background
The
live_test
has proven to be an extremely useful feature - it uploads a test file and checks whether BinaryAlert processed a YARA match for it or not (it's an end-to-end test).Since the archive analysis is achieved through a different path (
yextend
), we want to include archives in the live test to make sure those are being matched correctly.Changes
live_test
functionality into its own fileeicar.txt
andeicar.tar.gz.bz2
test files, both of which should match the EICAR YARA ruleTesting
live_test
over and overThe test coverage dropped about 3% just due to moving the
live_test
into its own file. We can add unit tests for it later if we want, but it's not a high priority because it's just testing logic