Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EICAR archive to live_test #90

Merged
merged 6 commits into from Dec 14, 2017
Merged

Add EICAR archive to live_test #90

merged 6 commits into from Dec 14, 2017

Conversation

austinbyers
Copy link
Collaborator

to: @chunyong-lin
cc: @airbnb/binaryalert-maintainers
size: medium

Background

The live_test has proven to be an extremely useful feature - it uploads a test file and checks whether BinaryAlert processed a YARA match for it or not (it's an end-to-end test).

Since the archive analysis is achieved through a different path (yextend), we want to include archives in the live test to make sure those are being matched correctly.

Changes

  • Moves the live_test functionality into its own file
  • Adds eicar.txt and eicar.tar.gz.bz2 test files, both of which should match the EICAR YARA rule
  • Minor S3 terraform change to delete expired object markers

Testing

  • Deploy to test account, and then running live_test over and over

The test coverage dropped about 3% just due to moving the live_test into its own file. We can add unit tests for it later if we want, but it's not a high priority because it's just testing logic

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 92.941% when pulling cd7dd18 on austin-delete-expired into cebb706 on master.

Copy link

@chunyong-lin chunyong-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunyong-lin
Copy link

@austinbyers I have stamped on this PR, but the branch has conflicts.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 92.99% when pulling 80db197 on austin-delete-expired into d443913 on master.

@austinbyers austinbyers merged commit b47720f into master Dec 14, 2017
@austinbyers austinbyers deleted the austin-delete-expired branch December 14, 2017 19:07
@austinbyers austinbyers added this to the v1.1.0 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants