modify the json decoder to support json array when looking for a timestamp #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nothing wrong with this code, but could we write a new class JitneyTimestampDecoder and have your code there please? You could refer to the class used in the properties file. We have a project ongoing where we are writing some DI classes to work with Jitney. the idea of picking a timestamp field by walking down the array may not be the best for that. not sure yet, the story there is evolving, so it seems better to keep this class unchanged. |
|
@krishnap cool, I've copied the file over into JitneyTimestampDecoder and adjusted the documentation accordingly |
|
👍 |
|
@airbnb/di FYI |
|
merging for @leezhang upon his request. |
krishnap
added a commit
that referenced
this pull request
Apr 21, 2015
…g_message_decoder modify the json decoder to support json array when looking for a timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krishnap @ericlevine
Modify the json decoder to support json array when looking for a timestamp
Currently jitney message is in this format
[{"eventType":"session-activity","id":"ae86fa9d-0332-4fb1-9560-4d020bd2eec2"...},{"sessionActivity":{"userId":1,"activityType":"test_activity","sessionId":"session_id"},"eventType":"session-activity"}]
basically an array of 2 json objects, the first one is the jitney meta data and the second one is the session activity payload, the current code is assuming the message is a json object per message and need to updated to support JSONArray