-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing window resize for explore and standalone #165
Conversation
@@ -217,6 +217,15 @@ var px = (function () { | |||
others += widget.find('.slice_header').height(); | |||
return widget.height() - others; | |||
}, | |||
setResizeOnWindowResize: function () { | |||
var resizeTimer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is basically to make sure that the function is called when the resizing is done, as opposed to calling the function a thousand times during the drag event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, then your browser won't crash :) nit I think bindResizeToWindowResize
is a better name but LGTM 👍
👍 |
Fixing window resize for explore and standalone
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
Updates the requirements on [jest-mock-console](https://github.com/bpedersen/jest-mock-console) to permit the latest version. - [Release notes](https://github.com/bpedersen/jest-mock-console/releases) - [Commits](https://github.com/bpedersen/jest-mock-console/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
…apache#165) * feat: add basic functionality for icicle chart to display static data adds functionality for the icicle chart to have data passed in and display (static, no interactions yet) * feat: increase code coverage to pass check * feat: clarify contentRenderer argument types
@williaster @askeys, this seems to do it