-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flagstore interface #686
flagstore interface #686
Conversation
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
@nikhilsimha I've made the featureFlags param in |
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Summary
Create a function in Api.scala that users can override to enable feature flag functionality
Why / Goal
Ability to safely roll out features in a controlled manner
Test Plan
Reviewers