Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flagstore interface #686

Merged
merged 19 commits into from
Apr 29, 2024
Merged

Conversation

divyamanohar-stripe
Copy link
Collaborator

@divyamanohar-stripe divyamanohar-stripe commented Feb 21, 2024

Summary

Create a function in Api.scala that users can override to enable feature flag functionality

Why / Goal

Ability to safely roll out features in a controlled manner

Test Plan

  • Covered by existing CI
  • tested in our environment, passing in our feature flag functionality to our Api class and verified we can turn off/on features in Chronon code

Reviewers

Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
@divyamanohar-stripe
Copy link
Collaborator Author

@nikhilsimha I've made the featureFlags param in Fetcher.scala nullable and it's now backwards compatible. I'm following the general same pattern of responseConsumer in Api.scala for this, lmk what you think

divyamanohar-stripe and others added 12 commits April 8, 2024 15:57
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Copy link
Contributor

@nikhilsimha nikhilsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean

@divyamanohar-stripe divyamanohar-stripe changed the title create feature flags function api flagstore interface Apr 25, 2024
Copy link
Collaborator

@caiocamatta-stripe caiocamatta-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
Signed-off-by: divyamanohar-stripe <111152273+divyamanohar-stripe@users.noreply.github.com>
@divyamanohar-stripe divyamanohar-stripe merged commit a05382e into main Apr 29, 2024
6 checks passed
@divyamanohar-stripe divyamanohar-stripe deleted the divyamanohar/feature-flags-api-chronon branch April 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants