[web-ui] Adding ability to few runtime stats in graph. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG ========= * Updated `components/duration_humanizer.js` to optionally abbreviate units. * Added `JobStatsAggregator` component, which takes a collection of models that have `stats` and `parents` fields defined, then aggregates on a specified stat. Rather fragile and fraught with assumptions at the moment. * Increased the time between polls in `components/pollable_collection.js`. * Merged disparate graph view templates into one. * Added `active` handlebars helper, which returns "active" if the two specified values are equivalent. * Slightly cleaned up `views/graph_viz_view.js` to incorporate the idea of graph decorators. In the long run, `GraphView` and `GraphVizView` will simply become decorators. (TODO(AK): Flesh out graph decorators.)
CHANGELOG ========= * Removed comments from `app/scripts/styles/pickadate.classic.css` which were causing the r.js tool to complain. * Removed node.js sniffing from `app/scripts/vendor/viz.js`, which caused an exception to be thrown while building assets.
andykram
added a commit
that referenced
this pull request
Apr 10, 2013
[web-ui] Adding ability to few runtime stats in graph.
andykram
added a commit
that referenced
this pull request
May 1, 2013
[web-ui] Adding ability to few runtime stats in graph.
Rob-Johnson
added a commit
to Rob-Johnson/chronos
that referenced
this pull request
Aug 18, 2016
add headers required for CORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
components/duration_humanizer.jsto optionally abbreviateunits.
JobStatsAggregatorcomponent, which takes a collection ofmodels that have
statsandparentsfields defined, then aggregateson a specified stat. Rather fragile and fraught with assumptions at
the moment.
components/pollable_collection.js.activehandlebars helper, which returns "active" if the twospecified values are equivalent.
views/graph_viz_view.jsto incorporate the ideaof graph decorators. In the long run,
GraphViewandGraphVizViewwill simply become decorators. (TODO(AK): Flesh out graph decorators.)