Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hooks Testing] Added Test cases for useState, useEffects & customHooks #2041

Open
wants to merge 29 commits into
base: master
from

Conversation

2 participants
@pgangwani
Copy link

pgangwani commented Mar 8, 2019

@ljharb @chenesan : Please review and add comments as this is my first PR. I expect some rework. Otherwise, cherrypick the commits as you said.

@pgangwani pgangwani changed the title Added Test cases for useState, useEffects & customHooks [Hooks Testing] Added Test cases for useState, useEffects & customHooks Mar 8, 2019

@pgangwani

This comment has been minimized.

Copy link
Author

pgangwani commented Mar 8, 2019

@ljharb : I know I have written test cases for ReactWrapper only. I will copy paste in shallowWrapper as its compatible , wanted to get review comments and then copy to ShallowWrapper spec file.

pgangwani and others added some commits Mar 8, 2019

@pgangwani

This comment has been minimized.

Copy link
Author

pgangwani commented Mar 8, 2019

[Update]: @ljharb : I have

  • copied test to shallowWrapper spec
  • Removed mount usage in shallowWrapper spec (review careefully)

@pgangwani pgangwani referenced this pull request Mar 8, 2019

Open

[WIP] Support React hooks `useState` #2008

4 of 7 tasks complete

@pgangwani pgangwani referenced this pull request Mar 9, 2019

Open

React hooks support checklist #2011

0 of 11 tasks complete
@ljharb
Copy link
Member

ljharb left a comment

Thanks! Some initial feedback.

@ljharb ljharb added this to v16.8+: Hooks in React 16 Mar 9, 2019

pgangwani and others added some commits Mar 10, 2019

Update packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
[AutoCommitted] review comments

Co-Authored-By: pgangwani <pawangangwani0@gmail.com>
Update packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
[AutoCommit] review comments

Co-Authored-By: pgangwani <pawangangwani0@gmail.com>
Update packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
[AutoCommit] review comments

Co-Authored-By: pgangwani <pawangangwani0@gmail.com>
Update packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
[AutoCommit] review comments

Co-Authored-By: pgangwani <pawangangwani0@gmail.com>
Update packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
[AutoCommit] review comments

Co-Authored-By: pgangwani <pawangangwani0@gmail.com>
Gangwani, Pawan
@pgangwani

This comment has been minimized.

Copy link
Author

pgangwani commented Mar 10, 2019

@ljharb Incorporated all comments/ suggested changes except one, opened a discussion.

Gangwani, Pawan and others added some commits Mar 10, 2019

@pgangwani

This comment has been minimized.

Copy link
Author

pgangwani commented Mar 10, 2019

@ljharb : Please review one more time as incorporated changes

Gangwani, Pawan

Gangwani, Pawan and others added some commits Mar 11, 2019

Gangwani, Pawan
Gangwani, Pawan
@pgangwani

This comment has been minimized.

Copy link
Author

pgangwani commented Mar 17, 2019

Added test cases for useContext & useReducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.