bug fix: getSeletors() #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selectors shouldn't be split by space, because selector itself can contain a space
Example: .find('div[data-foo="foo bar"]')
| <h1 data-foo="foo bar">Hello</h1> | ||
| </div> | ||
| ); | ||
| expect(wrapper.find('[data-foo="foo bar"]')).to.have.length(1); |
There was a problem hiding this comment.
Can you add another test to verify that attribute queries still work without the attribute value?
wrapper.find("[data-foo]")
|
@rifeljm can we make sure this works with/covers the following cases as well:
^ The spaces don't show in the example, but they're there 😄 |
- selectors shouldn't be cleaned of multiple spaces - added few more tests
|
@rifeljm can you update the branch with master? After that I think we can merge 👍 |
|
LGTM |
|
Thanks @rifeljm |
islemaster
added a commit
to islemaster/enzyme
that referenced
this pull request
Aug 4, 2016
Support for spaces in attribute selector values was added in 2.4.0 ([PR enzymejs#427](enzymejs#427)) but was not documented in the changelog. It took me a while to sort out why my selectors `option[value="by Alice"]` were working in 2.4.1 but not 2.3.0 ([see my gradual realization here](code-dot-org/code-dot-org#9830)). I'm recommending this get added to the changelog to save others some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectors shouldn't be split by space, because selector itself can contain a space
Example: .find('div[data-foo="foo bar"]')