Fix Incorrect Supplementary Item Found During WillDisplay and DidEndDisplaying Callbacks #147
Conversation
brynbodayle
force-pushed
the
bb-supplementary-view-display-callbacks-during-updates-fix
branch
from
5ca6ebe
to
21ea71c
Compare
brynbodayle
force-pushed
the
bb-supplementary-view-display-callbacks-during-updates-fix
branch
from
d5a8006
to
b47778b
Compare
Sources/EpoxyCollectionView/CollectionView/ReusableViews/CollectionViewReusableView.swift
Outdated
Show resolved
Hide resolved
| guard let view = view as? CollectionViewReusableView else { | ||
| // We don't assert since `UICollectionViewCompositionalLayout` can create and configure its | ||
| // own supplementary views e.g. with a `.list(using: .init(appearance: .plain))` config. | ||
| return |
There was a problem hiding this comment.
oof, this sucks. I know we're currently using the cell / reusable view as an easy way to store the item path, but maybe that isn't the right solution (given this limitation). TBH I'm cool with ignoring this for now, but we might need to address this in the future by maintaining a cell / reusable view => item path mapping ourselves.
There was a problem hiding this comment.
What is the limitation you're concerned about? We only need to provide callbacks and track the visibility of our own Epoxy-based views, not ones created internally by compositional layout.
There was a problem hiding this comment.
Oh, you're right. I was thinking we'd still want callbacks for those, but makes sense that we wouldn't since we're not making the epoxy models for them.
…ctionViewReusableView.swift Co-authored-by: Bryan Keller <kellerbryan19@gmail.com>
brynbodayle
deleted the
bb-supplementary-view-display-callbacks-during-updates-fix
branch
Change summary
How was it tested?
How did you verify that this change accomplished what you expected? Add more detail as needed.
Pull request checklist
All items in this checklist must be completed before a pull request will be reviewed.
CollectionViewConfigurationCHANGELOG.mdentry in the "Unreleased" section for any library changes