Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Revert "Refine UIKit to SwiftUI Measurement Strategies (#162)" #164

Conversation

brynbodayle
Copy link
Contributor

@brynbodayle brynbodayle commented Mar 14, 2024

This reverts commit fb869c4.

Change summary

  • ran into some issues with this new approach in the Airbnb app due to unwanted side effects in the measurement container, the calls to sizeThatFits need to be purely functional (as much as possible)
  • left sizing strategies demo in place

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Wrote automated tests
  • Built and ran on the iOS simulator
  • Built and ran on a device

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

@brynbodayle brynbodayle merged commit 06d9405 into airbnb:master Mar 14, 2024
9 checks passed
@brynbodayle brynbodayle deleted the bb-update-swiftui-measurement-strategies-revert branch March 14, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants