Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Generated Kotlin Extensions Don't Adhere to Constructor Nullability #449

Merged
merged 1 commit into from Jun 15, 2018
Merged

Fix Generated Kotlin Extensions Don't Adhere to Constructor Nullability #449

merged 1 commit into from Jun 15, 2018

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Jun 14, 2018

Fix for #448

I also cleaned up the code style settings with this

@elihart elihart mentioned this pull request Jun 14, 2018
Closed
ngsilverman
ngsilverman approved these changes Jun 15, 2018
View reviewed changes
Copy link
Contributor

@ngsilverman ngsilverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@elihart elihart merged commit c338f41 into master Jun 15, 2018
@elihart elihart deleted the eli-support_kotlin_nullability branch June 15, 2018 17:54
@elihart elihart mentioned this pull request Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngsilverman ngsilverman ngsilverman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elihart @ngsilverman