Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset controller state on failed model build #720

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Apr 1, 2019

The user's implementation of buildModels is wrapped in a try/catch so that if it fails
we can reset the state of this controller. This is useful when model building is done
on a dedicated thread, which may have its own error handler, and a failure may not
crash the app - in which case this controller would be in an invalid state and crash later
with confusing errors because "threadBuildingModels" and other properties are not
correctly set. This can happen particularly with Espresso testing.

@ngsilverman @BenSchwab

@elihart elihart merged commit ee0755a into master Apr 2, 2019
@elihart elihart deleted the eli-catch_build_models_error branch April 2, 2019 14:15
@elihart elihart mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant