Carousel building with Kotlin DSL - Step 1 #967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refresh from @elihart's pull request #850 about issue issue #847.
While we certainly need a more robust api so we could use the DSL for custom carousel (and Epoxy model) group I propose we do it step by step.
Where the first step is we merge this change :
ModelCollector
with required change in code-genEpoxyCarouselNoSnapBuilder.kt