Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use <include> in <template> on Alipay #140

Closed
1 of 6 tasks
malash opened this issue Dec 14, 2021 · 4 comments · Fixed by #183 or #213
Closed
1 of 6 tasks

Cannot use <include> in <template> on Alipay #140

malash opened this issue Dec 14, 2021 · 4 comments · Fixed by #183 or #213

Comments

@malash
Copy link
Collaborator

malash commented Dec 14, 2021

Description

When lib v2 being enabled, <include> in <template> cause compilation error on Alipay dev tool.

image

Reproduct link

lib2-issue.zip

Reproduct steps

  1. Unzip the file
  2. Open in Alipay dev tool 2.7.2

Impact

GojiJS use this feature to import leaf-components in components and fails to run on latest Alipay.

Temporary solution

Replace <include> with src's content.

Platforms

  • WeChat
  • Baidu ( including Xiaohongshu )
  • QQ
  • Alipay
  • Toutiao
  • KuaiApp
@malash malash mentioned this issue Nov 24, 2022
Merged
malash added a commit that referenced this issue Nov 25, 2022
@malash
add comment for fixing #140
d697fc1
@malash malash mentioned this issue Nov 25, 2022
Merged
malash added a commit that referenced this issue Nov 25, 2022
@malash
Merge pull request #183 from airbnb/comment
44bb080 
Add comment for fixing #140
@malash malash reopened this Nov 26, 2022
@malash
Copy link
Collaborator Author

malash commented Nov 26, 2022

Reopen because leaf-components still not work with lib v2.

@Veercodeprog
Copy link

@malash is this open?
i can try fixing

@Veercodeprog
Copy link

@malash can you explain what is needed to be done.
do we have to change the include and use src attribute to include this file?

@malash
Copy link
Collaborator Author

malash commented Aug 14, 2023

I have reported this issue to official forum but got no useful info
https://open.alipay.com/portal/forum/post/65101062

This problem becomes urgent and blocks Alipay miniapp development because Alipay force to use Lib v2 since rencently.

malash added a commit that referenced this issue Aug 14, 2023
@malash
prevent <include> in <template> on Alipay to fix #140
5ffcce0
malash added a commit that referenced this issue Aug 14, 2023
@malash
prevent <include> in <template> on Alipay to fix #140
9507fff
@malash malash mentioned this issue Aug 15, 2023
Merged
@malash malash linked a pull request Aug 15, 2023 that will close this issue
Prevent using <include> in <template> to fix #140 on Alipay #213
Merged
malash added a commit that referenced this issue Aug 15, 2023
@malash
Merge pull request #213 from airbnb/fix-140
a73cc2c 
Prevent using `<include>` in `<template>` to fix #140 on Alipay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@malash @Veercodeprog