Refactor template reuse & fix getSubtreeId
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malash
force-pushed
the
refactor-template-reuse
branch
2 times, most recently
from
2e7407f
to
aa1af92
Compare
malash
force-pushed
the
refactor-template-reuse
branch
from
aa1af92
to
52d8bc5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
item.wxmlto reuse existingchildren0.wxml.getSubtreeIdthat cause this function always returnundefined. The root cause is Refactor container code by introducing a new virtual root element #77 replace root container with newGOJI_VIRTUAL_ROOTelement but I forgot to update thegetSubtreeIdlogics.