[eslint config] set forbid-foreign-prop-types to "warn"

airbnb · Jun 21, 2018 · 951825c · 951825c
1 parent 25e711c
commit 951825c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/eslint-config-airbnb/rules/react.js b/packages/eslint-config-airbnb/rules/react.js
@@ -375,8 +375,9 @@ module.exports = {
 
     // Forbids using non-exported propTypes
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md
-    // TODO: enable?
-    'react/forbid-foreign-prop-types': ['off', { allowInPropTypes: true }],
+    // this is intentionally set to "warn". it would be "error", but it's only critical if you're using
+    // a babel transform to strip propTypes in production.
+    'react/forbid-foreign-prop-types': ['warn', { allowInPropTypes: true }],
 
     // Prevent void DOM elements from receiving children
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/void-dom-elements-no-children.md