Migrate eslint-plugin-react to PeerDependencies

[kwelch]

Shouldn't the react plugin be a Dependency or PeerDependency since it must be installed as a sibling of the config for it to properly list.

[ljharb]

That's a really good point. It's currently a devDependency.

I think I prefer it being a dep instead of a peer dep - anyone have any reason why a peer dep would be more appropriate?

[kwelch]

I was not sure of the difference between the two, so I would agree it is a dep.

[tleunen]

I think a peerDep is more appropriate here to avoid having it twice (if different versions are used?).
And because a direct dependency is required, specify it as a dev dependency here is not really needed

[ljharb]

(if it becomes a dep, it wouldn't be a dev dep, but if it's a peer dep, it would definitely also be a dev dep to ensure tests can pass without explicitly installing the dep)

[tleunen]

Oh yep, you're right.

[kwelch]

So just to confirm, it will be added as a peer dep. This is because as a peer dep it is installed properly for use as a dep and a devDep.

Is this correct?

[ljharb]

@kwelch as of npm 3, peer deps are not automatically installed anymore. I'm still not certain, but am leaning towards straight dep. If it is a peer dep, it would have to be both a peer dep and a dev dep.

[ljharb]

I ended up making this both a peer dep and a dev dep. I may make it a straight dep in the future but for now this will suffice.