Upgrade jsx-a11y to 6.0.2, enable more jsx-a11y rules #1482
Conversation
… `v6` - enable more a11y rules
| @@ -32,10 +32,6 @@ module.exports = { | |||
| // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md | |||
| 'jsx-a11y/aria-unsupported-elements': 'error', | |||
|
|
|||
| // disallow href "#" | |||
| // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/href-no-hash.md | |||
There was a problem hiding this comment.
this rule was removed in v6
| // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md | ||
| 'jsx-a11y/mouse-events-have-key-events': 'off', | ||
| 'jsx-a11y/mouse-events-have-key-events': 'error', |
There was a problem hiding this comment.
we already enable this in our codebase
| @@ -110,7 +105,7 @@ module.exports = { | |||
| // require onClick be accompanied by onKeyUp/onKeyDown/onKeyPress | |||
| // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md | |||
| // TODO: enable? | |||
| 'jsx-a11y/click-events-have-key-events': 'off', | |||
| 'jsx-a11y/click-events-have-key-events': 'error', | |||
There was a problem hiding this comment.
we already enable this in our codebase
|
The airbnb config won't be compatible with v6 of jsx-a11y for awhile; even when we're compatible with eslint v4, we'll still be stuck on v5 for a bit. (#1447) |
|
Closing until later then |
ljharb
force-pushed
the
swb--bumpjsx-a11y-6
branch
from
44ac940
to
72ad345
Compare
|
Any update on this, now that |
|
@kelset it will be included in the next semver-major of eslint-config-airbnb, but i want the latest release to sit for awhile first. |
|
@ljharb when will the next semver-major release be released? It's just that it's preventing us from upgrading eslint-plugin-jsx-a11y which in turn makes us unable to upgrade eslint. If it is going to be awhile longer then I can always fork this, no worries there. |
|
@justinhp i'm not sure what you mean; eslint-plugin-jsx-a11y v5 (which this config requires) works fine with any v3 or v4 eslint - so you shouldn't need to upgrade the a11y plugin in order to upgrade eslint. |
|
@ljharb thank you! I'm an idiot. I must have gotten confused with the various configs we have. appreciate the help! |
|
Once peerDependencies has been updated, will we be able to install |
|
@ryansully no, that's just the way peer deps work (requiring the install instructions) and that won't ever change until eslint itself comes up with a solution. |
|
What is the status of this? when will the next semver-major release be released? |
|
@scinos status: not yet. |
|
So when will this go live? |
|
@inoas same answer: not yet. |
ljharb
force-pushed
the
swb--bumpjsx-a11y-6
branch
from
72ad345
to
074b2f8
Compare
|
Whoot, but now the answer is |
To improve navigability by keyboard-only users. https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md This is required for eslint-config-airbnb 16+ airbnb/javascript#1482
To improve navigability by keyboard-only users. https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md This is required for eslint-config-airbnb 16+ airbnb/javascript#1482
To improve navigability by keyboard-only users. https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md This is required for eslint-config-airbnb 16+ airbnb/javascript#1482
To improve navigability by keyboard-only users. https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md This is required for eslint-config-airbnb 16+ airbnb/javascript#1482
eslint-plugin-jsx-a11y remains on 5 because of airbnb/javascript#1482
Upgrades eslint-plugin-jsx-a11y from 5 to 6, and enables more a11y related rules