Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.16] changed Enforce to avoid #1946

Merged
merged 1 commit into from Nov 5, 2018
+1 −1
Merged

[19.16] changed Enforce to avoid #1946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -2781,7 +2781,7 @@ Other Style Guides
```

<a name="whitespace--func-call-spacing"></a>
- [19.16](#whitespace--func-call-spacing) Enforce spacing between functions and their invocations. eslint: [`func-call-spacing`](https://eslint.org/docs/rules/func-call-spacing)
- [19.16](#whitespace--func-call-spacing) Avoid spaces between functions and their invocations. eslint: [`func-call-spacing`](https://eslint.org/docs/rules/func-call-spacing)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforce is correct; we’re enforcing “no spaces”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Enforce spacing' is little confusing, As It's not clear whether to add spaces or not. Although Example definitely makes this clear or one have to check the eslint doc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples and the linter config should make it clear; "enforce no spaces" or "enforce spaces" would both be correct.

Copy link
Contributor Author

@theBstar theBstar Oct 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" Enforce no spaces" or "Avoid spaces" makes it more cleaner than "Enforce spaces". Actually "Enforce spaces" does not make sense when we are enforcing "no spaces", while we are not strictly telling people to check the lint config. "Enforce no spaces" is good ( If we really want to stick with 'enforce' ). The guide is mostly self explanatory and this change will help to keep it intact.


```javascript
// bad
Expand Down