[17.2] Fixed linking #1960
Closed
[17.2] Fixed linking #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing 's' prevented the anchor link from working
sharmilajesupaul
approved these changes
Nov 20, 2018
ljharb
requested changes
Nov 20, 2018
| @@ -2249,7 +2249,7 @@ Other Style Guides | |||
| } | |||
| ``` | |||
|
|
|||
| <a name="control-statement--value-selection"></a> | |||
| <a name="control-statements--value-selection"></a> | |||
There was a problem hiding this comment.
While this appears to be a typo from the original commit, to prevent links from breaking, we need to keep the singular one forever.
Either we need to fix the links to point to the plural one, or, we should add an anchor tag here for both.
|
The approach with the second anchor is probably the best. Made a mistake by deleting the fork, so I'll close this PR here. |
kiku-jw
pushed a commit
to kiku-jw/javascript
that referenced
this pull request
Mar 7, 2019
See requested changes here: airbnb#1960 (review)
vunb
pushed a commit
to hsdt/javascript
that referenced
this pull request
Nov 27, 2019
See requested changes here: airbnb#1960 (review)
eugene2candy
pushed a commit
to eugene2candy/javascript
that referenced
this pull request
Apr 10, 2021
See requested changes here: airbnb#1960 (review)
passionSeven
added a commit
to passionSeven/javascript
that referenced
this pull request
Jan 27, 2023
See requested changes here: airbnb/javascript#1960 (review)
Binary-Ninja-007
pushed a commit
to Binary-Ninja-007/JavaScript_Style_Guide
that referenced
this pull request
Aug 13, 2023
See requested changes here: airbnb/javascript#1960 (review)
harry908nilson
pushed a commit
to marcolane/Javascriipt
that referenced
this pull request
Sep 1, 2023
See requested changes here: airbnb/javascript#1960 (review)
olehrab
pushed a commit
to olehrab/JavaScript
that referenced
this pull request
Sep 14, 2023
See requested changes here: airbnb/javascript#1960 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing 's' prevented the anchor link from working