Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markers to spaced-comment block for Flow types #1966

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@jeffvandyke
Copy link
Contributor

commented Nov 29, 2018

Tested in one of my projects - Flow allows a syntax for typing in comments, but these markers have to be added to not throw errors. Flow could do it with a space in between, but it seems like an easy enough style to allow, and a good one to follow.

@jeffvandyke

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

To bump this, and to make it easier to view the original motivation for this PR, I'll link to the page that describes how Flow can work with type declarations inside these comments: https://flow.org/en/docs/types/comments/

@ljharb
Copy link
Collaborator

left a comment

Looks fine overall.

@@ -491,11 +491,13 @@ module.exports = {
'spaced-comment': ['error', 'always', {
line: {
exceptions: ['-', '+'],
markers: ['=', '!'], // space here to support sprockets directives
// support sprockets directives

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 28, 2019

Collaborator

please move the comments back to being inline; line length isn't worth worrying about.

@ljharb

ljharb approved these changes Aug 10, 2019

Copy link
Collaborator

left a comment

Rebased and fixed.

@ljharb ljharb merged commit bb011c2 into airbnb:master Aug 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.