Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: import/no-cycle specifies Infinity #2249

Merged
merged 1 commit into from Jun 27, 2020
Merged

Conversation

philihp
Copy link

@philihp philihp commented Jun 20, 2020

The configuration of the rule import/no-cycle specifies a maxDepth of infinity, which while reasonable, causes an error. This can be replicated by checking out the repo, and running npm run lint

/packages/eslint-config-airbnb-base ❯ npm run lint
...
...
...
> eslint-config-airbnb-base@14.2.0 lint /Users/philihp/work/javascript/packages/eslint-config-airbnb-base
> eslint --report-unused-disable-directives .

Oops! Something went wrong! :(

ESLint: 7.3.0

Error: .eslintrc » ./index.js » /Users/philihp/work/javascript/packages/eslint-config-airbnb-base/rules/imports.js:
	Configuration for rule "import/no-cycle" is invalid:
	Value null should be integer.

/packages/eslint-config-airbnb-base ❯ node -v && npm -v
v14.4.0
6.14.5

Since Infinity is the default for the rule, removing this would resolve the error.

@philihp
Copy link
Author

philihp commented Jun 20, 2020

Closing, just saw #2246

@philihp philihp closed this Jun 20, 2020
@ljharb ljharb reopened this Jun 27, 2020
@ljharb ljharb force-pushed the no-cycle branch 2 times, most recently from 7e076c7 to c5bee75 Compare June 27, 2020 20:39
@ljharb ljharb merged commit c5bee75 into airbnb:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants