Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended links to rules and plugins #384

Merged
merged 1 commit into from Jul 2, 2015
Merged

Extended links to rules and plugins #384

merged 1 commit into from Jul 2, 2015

Conversation

bettiolo
Copy link
Contributor

@bettiolo bettiolo commented Jul 2, 2015

Added links to JSX plugin's documentation and some links to env documentation and plugins repositories

@hshoff
Copy link
Member

hshoff commented Jul 2, 2015

👍

hshoff added a commit that referenced this pull request Jul 2, 2015
Extended links to rules and plugins
@hshoff hshoff merged commit 8d2a833 into airbnb:master Jul 2, 2015
@justjake
Copy link
Collaborator

justjake commented Jul 2, 2015

Nice, thanks

@ljharb
Copy link
Collaborator

ljharb commented Jul 2, 2015

O.o Isn't this file supposed to be valid JSON, which can't have comments? Can eslint parse this?

@hshoff
Copy link
Member

hshoff commented Jul 2, 2015

@ljharb eslint can still parse it...I was surprised as well.

Once I discoverd eslint works with invalid JSON, I thought it would be more helpful to have an annotated version of the .eslintrc in the repo so folks could easily learn more as they go.

@justjake
Copy link
Collaborator

justjake commented Jul 2, 2015

It isn't necessarily valid JSON. As you can see here, there's a little bit of extra work needed to use it from Node: https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/index.js#L5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants