Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full license text #8

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Add full license text #8

merged 1 commit into from
Aug 31, 2018

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Aug 31, 2018

The MIT license explicitly requires to attach the full license text to the code or any distribution. Without this the license isn't fulfilled by the project itself and thus invalid.

This change should be released as a new patch version so it virally distributes to all projects depending on this library.

The MIT license explicitly requires to attach the full license text to the code or any distribution. Without this the license isn't fulfilled by the project itself and thus invalid.
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SPDX identifier is sufficient to hold weight in court, regardless of what the license requires, but adding this is fine. Thanks.

@ljharb ljharb merged commit b07b946 into airbnb:master Aug 31, 2018
@honzajavorek
Copy link
Contributor Author

honzajavorek commented Aug 31, 2018 via email

@honzajavorek honzajavorek deleted the patch-1 branch August 31, 2018 18:03
@honzajavorek
Copy link
Contributor Author

@ljharb

SPDX identifier is sufficient to hold weight in court

I'd love to live in such world, but unfortunately, different company lawyers have different opinions and it just all makes developers' life harder if the explicit license text isn't in place. Our lawyers won't let us use dependencies without it, and to my knowledge, they're not alone with such opinion. I agree this is not likely to be a major problem at court, but the whole point of legal departments is to avoid companies going to court, thus being often very defensive in what they consider okay.

It's not my passion to add licenses to every project I want to use, but it's currently the only way I can continue to work.

@ljharb
Copy link
Contributor

ljharb commented Aug 31, 2018

Lawyers' jobs are to evaluate risk vs reward, to minimize liability - paranoia is only useful to a point.

v2.1.1 and v1.7.1 are published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants