enable web publishing without approval #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danfrankj This does make it very hard to lock down instances of the knowledge repo, and I worry that it could be abused in some contexts. Perhaps it should be an option in the server configuration as to whether web posts require approval? |
|
I took a look at the source code for the web editor (not something I've really looked at much, that was largely the work of others). Looks like it is not locked down on the backend anyway, so this is a semantic UI change. Merging in to reflect actual backend permissions. Thanks @danfrankj |
matthewwardrop
force-pushed
the
df_web_publish
branch
from
cb0683b
to
bcf4a2b
Compare
matthewwardrop
force-pushed
the
df_web_publish
branch
from
bcf4a2b
to
12130e1
Compare
tanuj208
pushed a commit
to ElucidataInc/knowledge-repo
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to publish content without approval to the knowledge repo. I think this is essential if we aim to get more users via the webpost.
@earthmancash @NiharikaRay @matthewwardrop