Deploy with HTTPS for uwsgi and gunicorn #420
Conversation
|
✅ Build knowledge-repo 1.0.464 completed (commit 4e05a29ec6 by @dorianbrown) |
|
Thanks so much for this patch @dorianbrown ! Like your previous patches, this one is awesome and valuable. It does require some testing to make sure that everything is working well, and I am desperately short of time at the moment. I think things should lighten up in the next few weeks, and I'll circle back around to this. And yes.. having unittests for this would ease the manual testing burden substantially... if you have some time to write some, and can think of a way to do it sensibly, that would be amazing! |
There was a problem hiding this comment.
I made a slight convention change to avoid using too many local variables with similar sounding names (config and options sound quite similar). Otherwise, looks good. Thanks again @dorianbrown !
…d plotly.js dependency" This reverts commit 692b1b5.
Also added line to correct svg MIME type being changed to octet-stream over https. Added docker files to .gitignore (maybe not a good idea?)
|
✅ Build knowledge-repo 1.0.507 completed (commit df37f765f1 by @matthewwardrop) |
This reverts commit 36f670d.
Implemented https for gunicorn and uwsgi. Also added line to correct svg MIME type being changed to octet-stream over https. Added docker files to .gitignore (maybe not a good idea?)
Description of changeset:
In order to be able to deploy using HTTPS, I added an https flag and paths for cert/key files in the server config file. The uwsgi/gunicorn engines now look at the flag, and if true adds to necessary options to deploy with HTTPS.
Additionally
mimetypes.add_type('image/svg+xml', '.svg')was added to fix an issue with svg not having the correct MIME type (octet-stream) when using https.Test Plan:
At the moment the
run_tests.shdoesn't contain any tests for deployment. Maybe something we should add?Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj