Dispose of engine on child thread before performing operations. #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build knowledge-repo 1.0.534 completed (commit b2a10c72b8 by @matthewwardrop) |
|
I'm going to go ahead and merge this one @CPapadim . It's been working well for me with my MySQL setup. If it doesn't work for you, please let me know! |
tanuj208
pushed a commit
to ElucidataInc/knowledge-repo
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CPapadim This resolves my issues about database connections failing in oblique ways. Does this solve your issues too?
Replaces #445 (and solves #430)
Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj