Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle field and allow interactive specification of headers. #460

Merged
merged 1 commit into from Oct 3, 2018

Conversation

matthewwardrop
Copy link
Collaborator

@matthewwardrop matthewwardrop commented Oct 3, 2018

This patch-set improves the functionality around headers and their presentation.

In particular:

  • Adds support for a subtitle field.
  • Improves the rendering of headers (and removes the incorrect treatment of document title as a header; freeing up h1 for proper use).
  • Improves readability by slightly increase font size and reducing maximum page width.
  • Allows for interactive specification of missing but required headers (will be accessible via the new kp tooling).
  • Slightly improves the styling associated with headers, which formerly could be smaller than the body text.
  • Fixes requirement for updated_at header to be present even though it is later overwritten.

screenshot from 2018-10-03 13-46-07

Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj

@matthewwardrop matthewwardrop force-pushed the mw_header_improvements branch 4 times, most recently from 9af6022 to 92ddd66 Compare October 3, 2018 20:40
@matthewwardrop matthewwardrop force-pushed the mw_header_improvements branch 7 times, most recently from 7d9ce7a to 9611db5 Compare October 3, 2018 21:28
@airbnb airbnb deleted a comment from AppVeyorBot Oct 3, 2018
@airbnb airbnb deleted a comment from AppVeyorBot Oct 3, 2018
@airbnb airbnb deleted a comment from AppVeyorBot Oct 3, 2018
@airbnb airbnb deleted a comment from AppVeyorBot Oct 3, 2018
@airbnb airbnb deleted a comment from AppVeyorBot Oct 3, 2018
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@matthewwardrop
Copy link
Collaborator Author

@danfrankj I've checked this over pretty rigorously locally. Merging in now. Let me know if you see anything concerning retrospectively.

@matthewwardrop matthewwardrop merged commit 50191b4 into master Oct 3, 2018
@matthewwardrop matthewwardrop deleted the mw_header_improvements branch October 3, 2018 23:18
tanuj208 pushed a commit to ElucidataInc/knowledge-repo that referenced this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants