404 pages instead of errors #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build knowledge-repo 1.0.597 completed (commit 251fde4fe5 by @wooddar) |
matthewwardrop
approved these changes
Oct 8, 2018
tanuj208
pushed a commit
to ElucidataInc/knowledge-repo
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to change the page not found behaviour of Knowledge Repo. Before, when a page could not be found, an error page was being shown to the user - now a friendly 404 page can be shown. Knowledge admins can change the
404.gifstatic file to customise this page for their organisation.Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj