Add explicit thumbnail resizing for thumbnails. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build knowledge-repo 1.0.600 completed (commit 2e2e213f58 by @matthewwardrop) |
matthewwardrop
force-pushed
the
mw_thumbnails
branch
from
4216e97
to
607a1b9
Compare
tanuj208
pushed a commit
to ElucidataInc/knowledge-repo
that referenced
this pull request
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when thumbnails are too large, the base64 encoded string representing the image can exceed the typical limit of 65535 characters on the thumbnail field in the model. This patch fixes this by explicitly resizing the thumbnail on index generation.
Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj