Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XSS vulnerability by escaping comments #558

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fix XSS vulnerability by escaping comments #558

merged 1 commit into from
Jun 3, 2020

Conversation

naoyak
Copy link
Collaborator

@naoyak naoyak commented May 30, 2020 •
edited
Loading

Description of changeset:

Fix #431, fix #254

Test Plan:

Enter the following in a post comment:

<script>alert("Client side attacks is possible here!");</script>

@AppVeyorBot
Copy link

✅ Build knowledge-repo 1.0.867 completed (commit a295d9e21f by @naoyak)

@naoyak
Copy link
Collaborator Author

naoyak commented Jun 3, 2020

Verified that this quick hack seems to fix the problem. @bulam

@naoyak naoyak requested a review from bulam June 3, 2020 07:03
bulam
bulam approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@bulam bulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naoyak naoyak merged commit f026ad2 into master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulam bulam bulam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XSS vulnerability XSS vulnerabilities in comments marked as safe
3 participants
@naoyak @AppVeyorBot @bulam