Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request LottieCompositionFactory fromXXXInputStream close param to be public. #2252

Closed
peerless2012 opened this issue Mar 1, 2023 · 3 comments · Fixed by #2286 or #2319
Closed

Request LottieCompositionFactory fromXXXInputStream close param to be public. #2252

peerless2012 opened this issue Mar 1, 2023 · 3 comments · Fixed by #2286 or #2319
Labels
New feature

Comments

@peerless2012
Copy link
Contributor

I use Lottie in Glide, and decode it in ResourceDecoder which has InputStream, when I use LottieCompositionFactory.fromJsonInputStreamSync and LottieCompositionFactory.fromZipStreamSync, they all close the InputStream, but I don't want LottieCompositionFactory close the InputStream.

I think, make the private LottieCompositionFactory.fromJsonReaderSyncInternal and LottieCompositionFactory.fromZipStreamSyncInternal to be public will be better.
@gpeal gpeal mentioned this issue May 7, 2023
Merged
gpeal added a commit that referenced this issue May 7, 2023
@gpeal
Allow for non-closing input stream parsing (#2286)
cb2c4d5 
Fixes #2252
@gpeal
Copy link
Collaborator

gpeal commented May 9, 2023

Reopening to add support for zipinputstream

@gpeal gpeal reopened this May 9, 2023
@gpeal gpeal mentioned this issue Jun 18, 2023
Merged
gpeal added a commit that referenced this issue Jun 18, 2023
@gpeal
Add close parameters to LottieCompositionFactory.fromZipStream (#2319)
669ddb2 
Closes #2252
@peerless2012
Copy link
Contributor Author

When will publish this feature ?

@gpeal
Copy link
Collaborator

gpeal commented Jun 25, 2023

I'll probably publish 6.1.0 soon

@peerless2012 peerless2012 mentioned this issue Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New feature
Projects
None yet
Milestone
No milestone
2 participants
@gpeal @peerless2012