[Breaking Change] Automatic hardware acceleration detection #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7gkb
pushed a commit
to greg7gkb/lottie-react-native
that referenced
this pull request
May 11, 2019
…instead this property is auto-detected. See: airbnb/lottie-android#1048
plouh
pushed a commit
to plouh/lottie-react-native
that referenced
this pull request
May 24, 2019
…instead this property is auto-detected. See: airbnb/lottie-android#1048
plouh
pushed a commit
to plouh/lottie-react-native
that referenced
this pull request
Jul 8, 2019
…instead this property is auto-detected. See: airbnb/lottie-android#1048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dash path effects are the only feature that Lottie uses that isn't supported on all api levels. We should be able to safely detect this one case for API < 28 and turn on hardware acceleration otherwise.
This removes the existing APIs since they no longer have a function.