Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear onVisibleAction once the action is taken #2066

Merged
merged 1 commit into from Apr 24, 2022
Merged

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Apr 23, 2022

The root cause of #2053 is that once the fragment was paused and resumed, the onResumeAction was set to RESUME and never cleared. The compass view in the linked project triggered a relayout on every frame which caused the visibility action run over and over again. The animation itself happens to have an empty first frame so it appeared as if the animation disappeared.

Fixes #2053

@LottieSnapshotBot
Copy link

@LottieSnapshotBot LottieSnapshotBot commented Apr 24, 2022

Snapshot Tests
28: Report Diff

@gpeal gpeal merged commit 61e8844 into master Apr 24, 2022
4 checks passed
@gpeal gpeal deleted the gpeal/fragment-pager branch Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants