Support re-initialize #2323
Merged
Support re-initialize #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L.setCacheProvider are called, respectively
drewhamilton
commented
Jun 23, 2023
gpeal
reviewed
Jun 24, 2023
gpeal
reviewed
Jul 10, 2023
|
I'm looking into the CI failure. For now, you can ignore it |
gpeal
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2245, see details there. This resets
L.networkFetcherinL.setFetcher, and resetsL.networkCacheinL.setCacheProvider, ensuring that the public fetcher and cache provider are never out of sync with their respective internal implementations.LottieInitializeTestverifies this by simulating two tests run with differentTemporaryFolderinstances. The new test fails if either of the twoLproperties are not reset.