Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring a default global value for async updates #2356

Merged
merged 2 commits into from Sep 2, 2023

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Aug 10, 2023

No description provided.

@github-actions
Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit c76b9f0 into master Sep 2, 2023
6 checks passed
@gpeal gpeal deleted the gpeal/async-updates-default branch September 2, 2023 23:54
@UKMIITB
Copy link

UKMIITB commented Mar 5, 2024

@gpeal
How do we set this in our app ?
Couldn't find documentation regarding this

@gpeal
Copy link
Collaborator Author

gpeal commented Mar 5, 2024

@UKMIITB Lottie.initialize(LottieConfig.Builder().….build())

@UKMIITB
Copy link

UKMIITB commented Mar 5, 2024

@gpeal
Should this be defined in onCreate of application class ?

Also if we are building an SDK, then where should I ideally define this ?

@gpeal
Copy link
Collaborator Author

gpeal commented Mar 5, 2024

@UKMIITB Yes, it should be somewhere around app startup.

This probably isn't recommended if you are creating an SDK because it will overwrite the caller's settings if they have set it. If you control LottieDrawable/LottieAnimationView/LottieAnimation composable in your SDK, you can enable async updates manually on each view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants