Add ability to load dotLottie via LottieAnimationView #2410
Conversation
| * <p> | ||
| * Auto-closes the stream. | ||
| */ | ||
| public void setAnimationFromDotLottie(ZipInputStream stream, @Nullable String cacheKey) { |
There was a problem hiding this comment.
| public void setAnimationFromDotLottie(ZipInputStream stream, @Nullable String cacheKey) { | |
| public void setAnimation(ZipInputStream stream, @Nullable String cacheKey) { |
You can give this the same name. The method overloading specificity is enough here.
It's worth noting that dotLottie aren't the only zip files Lottie supports. You can zip any animations or animations + images so the naming/docs should not be dotLottie specific.
I was on a plane yesterday and actually drafted up a similar PR. I'm happy to land your contribution since you got it first, however.
There was a problem hiding this comment.
Makes sense! I don't have a strong opinion on which PR we land. Maybe yours, since I like your docs more 😄
There was a problem hiding this comment.
Okay, up to you. Feel free to update it or close it and then I'll land mine.
CI usually runs fine from forks, not sure why the token is missing for this PR.
|
Closing in favor of #2411 |
Relevant issue: #2409
Adds a
setAnimationFromDotLottie()method toLottieAnimationViewthat accepts aZipInputStream.