Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect autoPlay when setting a new composition #2469

Merged
merged 1 commit into from
Feb 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,9 @@ public void setComposition(@NonNull LottieComposition composition) {
this.composition = composition;
ignoreUnschedule = true;
boolean isNewComposition = lottieDrawable.setComposition(composition);
if (autoPlay) {
lottieDrawable.playAnimation();
}
ignoreUnschedule = false;
if (getDrawable() == lottieDrawable && !isNewComposition) {
// We can avoid re-setting the drawable, and invalidating the view, since the composition
Expand Down Expand Up @@ -1078,6 +1081,7 @@ public <T> void addValueCallback(KeyPath keyPath, T property,

@MainThread
public void cancelAnimation() {
autoPlay = false;
userActionsTaken.add(UserActionTaken.PLAY_OPTION);
lottieDrawable.cancelAnimation();
}
Expand Down