Support combining shapes with different keyframe timings into the same CAShapeLayer #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Aug 4, 2022
Sources/Private/CoreAnimation/Animations/CombinedShapeAnimation.swift
Outdated
Show resolved
Hide resolved
calda
force-pushed
the
cal--improved-combined-shapes
branch
from
a8ceb2a
to
0bd6d3c
Compare
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for combining shapes with different keyframe timings into the same
CALayer.We have to render all shapes in the same
CAShapeLayer, or their fills may render incorrectly in places where the shapes overlap. We previously only did this when all of the shapes shared the exact same keyframe timing values.In cases where the shapes have different keyframe timing values, we now combine them by manually interpolating the paths at each frame. This is similar to how we support path trims as of #1612.