Update LottieConfiguration to use DecodingStrategy. dictionaryBased by default #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
commented
Oct 17, 2022
| /// Use Codable. This is the default strategy introduced on Lottie 3. | ||
| /// Use Codable. This is was the default strategy introduced on Lottie 3, but should be rarely | ||
| /// used as it's slower than `dictionaryBased`. Kept here for any possible compability issues | ||
| /// that may come up, but consider it soft-deprecated. |
There was a problem hiding this comment.
is calling it soft-deprecated too strong?
There was a problem hiding this comment.
I expect we'll never completely remove the Codable conformances on our models, since it seems reasonable to continue providing a Codable conformance for convenience (and since removing this would be source-breaking).
I do think it makes sense to call this case "legacy" or "deprecated" though, since it's no longer recommended. I think we may as well change it to case legacyCodable now. Thoughts?
There was a problem hiding this comment.
We could still have the Codable conformance, but eventually remove this convenience around using it. I'll rename it to legacyCodable for now.
calda
reviewed
Oct 17, 2022
calda
reviewed
Oct 17, 2022
calda
approved these changes
Oct 17, 2022
Co-authored-by: Cal Stephens <cal@calstephens.tech>
Co-authored-by: Cal Stephens <cal@calstephens.tech>
calda
pushed a commit
that referenced
this pull request
Nov 28, 2022
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1776