Update minimum Swift version to 5.5 #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Oct 21, 2022
| @@ -193,12 +193,12 @@ extension GradientShapeItem { | |||
| for colorIndex in 0..<numberOfColors { | |||
| let colorStartIndex = colorIndex * 4 | |||
|
|
|||
| let colorLocation = CGFloat(colorComponents[colorStartIndex]) | |||
| let colorLocation = Double(colorComponents[colorStartIndex]) | |||
There was a problem hiding this comment.
banished CGFloat to the shadow realm
There was a problem hiding this comment.
One of these CGFloat changes causes the Xcode 13.2 build to fail with a weird and unhelpful Illegal instruction: 4 error, so I reverted those changes
erichoracek
approved these changes
Oct 21, 2022
This reverts commit 0a28b2f.
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lottie 4.0 is a good opportunity for us to update our minimum-supported Swift version.
This PR updates this repo to require Swift 5.5 and Xcode 13.0+