Change veryLargeRect size to fix issue with masks (#1880) #1884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using scaleToFill / scaleAspectFit / scaleAspectFill mode with an animation that has a subtract mask, the animation could sometimes fail to render.
veryLargeRect
is used as the size of the "bounds" rect from which the path is subtracted.Alternative considered
I digged through the old code and found that the old Objective-C implementation actually passed in the bounds size.
I guess that could be an alternative solution if needed.
502b18ff#diff-233d9c9fcd51dcb99d9884451e850073e2712d14d3c05e0e91bae1c551abe91eR42
Video capture before/after the change
iPhone14 Pro Simulator
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-12-29.at.15.41.19.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-12-29.at.15.41.47.mp4