Fix issue where negative scale.x values didn't render correctly on iOS 14
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Jan 4, 2023
erichoracek
reviewed
Jan 4, 2023
| context.logger.warn(""" | ||
| Negative `scale.x` values are not displayed correctly in snapshot tests | ||
| """) | ||
| } | ||
| } else { | ||
| if !osSupportsNegativeScaleValues, hasNegativeXScaleValues { |
There was a problem hiding this comment.
I'm a bit confused how this fixes the issue, isn't this just logging an extra warning?
There was a problem hiding this comment.
The logCompatibilityIssue and compatibilityAssert methods cause RenderingEngineOption.automatic to detect that the animation is unsupported by the core animation engine and should fall-back to using the main thread rendering engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where negative
scale.xvalues didn't render correctly on iOS 14 when usingRenderingEngineOption.automatic. Fixes #1882.I imagine there's a way to support this properly on iOS 14 and earlier, but I think it's better to just throw a compatibility error in this case: