Fix issue where play(fromProgress: 1, toProgress: 0) animation would not actually play
#1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d not actually play
calda
commented
Jan 9, 2023
| case .playOnce: | ||
| animationContext.playFrom = currentFrame | ||
| if animationContext.playTo != currentFrame { |
There was a problem hiding this comment.
This is basically the same logic that the Main Thread rendering engine has here: https://github.com/airbnb/lottie-ios/blob/master/Sources/Public/Animation/LottieAnimationView.swift#L1422
calda
commented
Jan 9, 2023
| @@ -65,6 +65,7 @@ final class AnimationViewTests: XCTestCase { | |||
| let tests: [(fromFrame: AnimationFrameTime?, toFrame: AnimationFrameTime)] = [ | |||
| (fromFrame: nil, toFrame: 10), | |||
| (fromFrame: 8, toFrame: 14), | |||
| (fromFrame: 14, toFrame: 0), | |||
There was a problem hiding this comment.
Added a test case for this, which fails on master
erichoracek
approved these changes
Jan 9, 2023
Co-authored-by: Eric Horacek <eric.horacek@airbnb.com>
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
…d not actually play (airbnb#1908)
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
…d not actually play (airbnb#1908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where animations would be ignored when
toFrame == currentFrame. For example, when playing from 100% to 0% when the animation view is created (andcurrentFrame == 0), the animation was previously ignored. Fixes #1901 and #1907.