Add dotLottie error handling #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
approved these changes
Feb 21, 2023
| @@ -52,7 +52,10 @@ extension FileManager { | |||
| // MARK: - DotLottieError | |||
|
|
|||
| public enum DotLottieError: Error { | |||
| case invalidFileFormat | |||
There was a problem hiding this comment.
Since this is public I think we need to preserve these enum cases, otherwise this would be a breaking change. Could we deprecate the existing cases instead of removing them?
There was a problem hiding this comment.
Haha oops accidentally merged the PR after I finished reviewing it. I posted a follow-up PR to add back these three public enum cases: #1970
There was a problem hiding this comment.
Agree, it makes sense to keep them until the next minor/major version is released.
| return NSDataAsset(name: assetName, bundle: bundle)?.data | ||
| if let asset = NSDataAsset(name: assetName, bundle: bundle) { | ||
| self = asset.data | ||
| return |
There was a problem hiding this comment.
Is this necessary? It seems like it may be redundant
Suggested change
| return |
calda
added a commit
that referenced
this pull request
Feb 21, 2023
calda
added a commit
that referenced
this pull request
Mar 11, 2023
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously discussed in #1957.
LottieLoggerwarnings to methods loading from dotLottie.animationUrlproperty from DotLottieAnimation.Propagating errors has actually made the error handling shorter and easier to debug.