Update ZIPFoundation to 0.9.16 #1978
Conversation
| var generator: String | ||
| var version: String? | ||
| var author: String? | ||
| var generator: String? |
There was a problem hiding this comment.
The animation in #1945 was also failing to load because the manifest didn't provide these properties. Seems fine to make them optional, especially since we don't use these anywhere.
| @@ -0,0 +1,24 @@ | |||
| ## ZipFoundation | |||
There was a problem hiding this comment.
Added some more discussion about our ZIPFoundation dependency, plus instructions for if we have to update this again in the future.
|
|
||
| Due to limitations of these package managers, we can't depend on / import | ||
| a separate ZIPFoundation module / library. Instead, we include the source | ||
| directly within the Lottie library and compile everything as a single unit. |
There was a problem hiding this comment.
At least updating to the most recent version was painless
|
|
||
| 2. Update the URL at the top of this file to indicate what release is being used. | ||
|
|
||
| 3. Change all of the `public` symbols defined in this module to instead be `internal` |
There was a problem hiding this comment.
Do we have a script that automates this? might be useful to write as a rake task
There was a problem hiding this comment.
We'll have to do this pretty infrequently (ideally never but we'll see), so I don't think we need a script for now. If we end up having to do this more regularly then a script would make sense
|
Does version 4.1.3 not yet include this update? |
|
I am receiving a build warning when installing via cocoapods:
Any thoughts? |
|
Could you file an issue? Seems worth fixing |
This PR updates our ZIPFoundation dependency to
0.9.16. This fixes #1945, where a dotLottie file would fail to load with acorruptedDataerror due to an issue in the version of ZIPFoundation that we were previously using.It's still not really ideal that we integrate ZIPFoundation via source, but it's still the best option. I went ahead and added a README.md to our ZIPFoundation folder that includes a bit of discussion plus instructions for how to update this in the future if necessary.