Fix issue where Trim strokeStart / strokeEnd could be rendered in incorrect order #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Apr 27, 2023
| // Otherwise if the start / end values ever swap places we have to | ||
| // fix the order on a per-keyframe basis, which may require manually | ||
| // interpolating the keyframe values at each frame. | ||
| (strokeStart, strokeEnd) = interpolatedAtEachFrame() |
There was a problem hiding this comment.
nice use of dual assignment!
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
TrimstrokeStart/strokeEndvalues could be rendered in an incorrect order.Core Animation requires that
strokeStartalways be less than or equal tostrokeEnd. Previously we only handled cases wherestrokeStartwas either always greater than or always less thanstrokeEnd. Now we also handle cases wherestrokeStartandstrokeEndswap places some time during the animation. Fixes #1972.