Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .../ZipFoundation/README.md from targets and *.md files from podspec #2057

Merged
merged 2 commits into from
May 4, 2023

Conversation

reggian
Copy link
Contributor

@reggian reggian commented May 4, 2023

  • README.md files do not need to be included in the Frameworks so the .../ZipFoundation/README.md is removed from all the Framework targets.
  • In general the *.md files are not considered as sources thus the exclusion filter is introduced in lottie-ios.podspec

Resolves #2056

Copy link
Member

@calda calda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calda calda merged commit 731e349 into airbnb:master May 4, 2023
11 checks passed
@reggian reggian deleted the rga--remove-readme-from-targets--2056 branch May 5, 2023 09:26
@JPowell23
Copy link

As @calda mentioned, this is still an issue. Tried even deleting the README from the specified location, cleaning the build, and restarting Xcode also did not fix the issue.
CleanShot 2023-08-05 at 11 37 07@2x

@calda
Copy link
Member

calda commented Aug 5, 2023

We haven't released a new version since this PR was merged. We plan on releasing a new version soon.

@PeterCheungHK
Copy link

Any Update for this?

@calda
Copy link
Member

calda commented Sep 9, 2023

I think we're ready to release the next version now. I'll just need to write some documentation and an announcement (lots of stuff in the new update!).

cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 15, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor |
`from: "4.2.0"` -> `from: "4.3.0"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.3.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.0)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.2.0...4.3.0)

**Lottie 4.3.0** adds many new features, including:

-   Official support for SwiftUI!
-   A public Core Animation `CALayer` subclass
-   Support for reduced motion
-   Support for drop shadow layer effects
-   Support for visionOS in the lottie-ios repo

You can learn more about Lottie 4.3.0 in this announcement: **[Lottie
4.3.0 now available, with official support for SwiftUI
#&#8203;2189](https://togithub.com/airbnb/lottie-ios/discussions/2189)**

#### New Features

-   Add SwiftUI `LottieView`, which wraps UIKit `LottieAnimationView`
- Add SwiftUI `LottieSwitch`, which wraps UIKit `AnimatedSwitch`
([airbnb/lottie-ios#2138)
- Add SwiftUI `LottieButton`, which wraps `AnimatedButton`
([airbnb/lottie-ios#2139)
- `AnimatedSwitch` and `AnimatedButton` now support macOS
([airbnb/lottie-ios#2138,
[airbnb/lottie-ios#2139)
- Add `LottieAnimationLayer`, a Core Animation `CALayer` subclass for
playing Lottie animations
([airbnb/lottie-ios#2073)
- Add support for rendering drop shadow layer effects
([airbnb/lottie-ios#2142)
- Add API for playing multiple markers sequentially
([airbnb/lottie-ios#2084)
- Play "reduced motion" marker if
`UIAccessibility.isReduceMotionEnabled` is true
([airbnb/lottie-ios#2110)
- Update text provider API to use full `AnimationKeypath` values
([airbnb/lottie-ios#2183)
- Add support for visionOS to lottie-ios repo
([airbnb/lottie-ios#2152)
- Drop support for Swift 5.5
([airbnb/lottie-ios#2152)
- Add contents gravity configuration to `AnimationImageProvider`
([airbnb/lottie-ios#2177)
- Add support for customizing stroke width values using
`FloatValueProvider`
([airbnb/lottie-ios#2179)
- Adopt `Sendable` to support using Lottie with strict concurrency
enabled
([airbnb/lottie-ios#2126)
- Add `LottiePlaybackMode` to support declarative playback configuration
([airbnb/lottie-ios#2128)
- Add option make main thread rendering engine force display update on
every frame
([airbnb/lottie-ios#2168)
- Add a option to prevent caching images from `AnimationImageProvider`
([airbnb/lottie-ios#2171)
- Add support for customizing gradient values using
`GradientValueProvider`
([airbnb/lottie-ios#2182)
- Added additional support for multiple animations in `DotLottieFile`
([airbnb/lottie-ios#2074)
- Add helper method to initialize `DotLottieFile` with data
([airbnb/lottie-ios#2090)

#### Bug fixes

- Remove `.../ZipFoundation/README.md` from targets and `*.md*` files
from podspec
([airbnb/lottie-ios#2057
- Fix issue where layers with negative X scale values could be pixelated
([airbnb/lottie-ios#2067)
- Fix warnings when building with Swift 5.9
([airbnb/lottie-ios#2072)
- Restructure `ValueProviderStore` to not accumulate multiple values for
the same key
([airbnb/lottie-ios#2082)
- Disable bitcode when building XCFramework
([airbnb/lottie-ios#2121)
- Fix unhandled file warning when building with SPM
([airbnb/lottie-ios#213)
- Fix support for customizing color of `SolidLayer` using
`ColorValueProvider`
([airbnb/lottie-ios#2154)
- Fix issue where shape items could be unexpectedly ignored
([airbnb/lottie-ios#2156)
- Fix issue where skew keyframes would unexpectedly not animate
([airbnb/lottie-ios#2157)
- Fix issue where value providers could be ignored when falling back to
main thread rendering engine
([airbnb/lottie-ios#2164)

Thanks to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45My4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 22, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.3.0"` -> `from: "4.3.1"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.3.1`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.1)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.0...4.3.1)

**Lottie 4.3.0** adds many new features, including:

-   Official support for SwiftUI!
-   A public Core Animation `CALayer` subclass
-   Support for reduced motion
-   Support for drop shadow layer effects
-   Support for visionOS

You can learn more about Lottie 4.3.0 in this announcement: **[Lottie
4.3.0 now available, with official support for SwiftUI
#&#8203;2189](https://togithub.com/airbnb/lottie-ios/discussions/2189)**

Lottie 4.3.1 fixes a small regression introduced by 4.3.0:
[airbnb/lottie-ios#2193

#### New Features

-   Add SwiftUI `LottieView`, which wraps UIKit `LottieAnimationView`
- Add SwiftUI `LottieSwitch`, which wraps UIKit `AnimatedSwitch`
([airbnb/lottie-ios#2138)
- Add SwiftUI `LottieButton`, which wraps `AnimatedButton`
([airbnb/lottie-ios#2139)
- `AnimatedSwitch` and `AnimatedButton` now support macOS
([airbnb/lottie-ios#2138,
[airbnb/lottie-ios#2139)
- Add `LottieAnimationLayer`, a Core Animation `CALayer` subclass for
playing Lottie animations
([airbnb/lottie-ios#2073)
- Add support for rendering drop shadow layer effects
([airbnb/lottie-ios#2142)
- Add API for playing multiple markers sequentially
([airbnb/lottie-ios#2084)
- Play "reduced motion" marker if
`UIAccessibility.isReduceMotionEnabled` is true
([airbnb/lottie-ios#2110)
- Update text provider API to use full `AnimationKeypath` values
([airbnb/lottie-ios#2183)
- Add support for visionOS
([airbnb/lottie-ios#2152)
- Drop support for Swift 5.5
([airbnb/lottie-ios#2152)
- Add contents gravity configuration to `AnimationImageProvider`
([airbnb/lottie-ios#2177)
- Add support for customizing stroke width values using
`FloatValueProvider`
([airbnb/lottie-ios#2179)
- Adopt `Sendable` to support using Lottie with strict concurrency
enabled
([airbnb/lottie-ios#2126)
- Add `LottiePlaybackMode` to support declarative playback configuration
([airbnb/lottie-ios#2128)
- Add option make main thread rendering engine force display update on
every frame
([airbnb/lottie-ios#2168)
- Add a option to prevent caching images from `AnimationImageProvider`
([airbnb/lottie-ios#2171)
- Add support for customizing gradient values using
`GradientValueProvider`
([airbnb/lottie-ios#2182)
- Added additional support for multiple animations in `DotLottieFile`
([airbnb/lottie-ios#2074)
- Add helper method to initialize `DotLottieFile` with data
([airbnb/lottie-ios#2090)

#### Bug fixes

- Remove `.../ZipFoundation/README.md` from targets and `*.md*` files
from podspec
([airbnb/lottie-ios#2057
- Fix issue where layers with negative X scale values could be pixelated
([airbnb/lottie-ios#2067)
- Fix warnings when building with Swift 5.9
([airbnb/lottie-ios#2072)
- Restructure `ValueProviderStore` to not accumulate multiple values for
the same key
([airbnb/lottie-ios#2082)
- Disable bitcode when building XCFramework
([airbnb/lottie-ios#2121)
- Fix unhandled file warning when building with SPM
([airbnb/lottie-ios#213)
- Fix support for customizing color of `SolidLayer` using
`ColorValueProvider`
([airbnb/lottie-ios#2154)
- Fix issue where shape items could be unexpectedly ignored
([airbnb/lottie-ios#2156)
- Fix issue where skew keyframes would unexpectedly not animate
([airbnb/lottie-ios#2157)
- Fix issue where value providers could be ignored when falling back to
main thread rendering engine
([airbnb/lottie-ios#2164)

Thanks to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 27, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.3.1"` -> `from: "4.3.2"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.3.2`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.2)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.1...4.3.2)

**Lottie 4.3.0** adds many new features, including:

-   Official support for SwiftUI!
-   A public Core Animation `CALayer` subclass
-   Support for reduced motion
-   Support for drop shadow layer effects
-   Support for visionOS in the lottie-ios rep

You can learn more about Lottie 4.3.0 in this announcement: **[Lottie
4.3.0 now available, with official support for SwiftUI
#&#8203;2189](https://togithub.com/airbnb/lottie-ios/discussions/2189)**

#### Lottie 4.3.2

Lottie 4.3.2 redesigns the `LottiePlaybackMode` playback APIs that were
introduced in Lottie 4.3.0.

##### Before

```swift
// Loop from 0.5 to 1.0
LottieView(animation: myAnimation)
  .play(.fromProgress(0.5, toProgress: 1.0, loopMode: .loop))

// Pause at the halfway point of the animation
LottieView(animation: myAnimation)
  .play(.progress(0.5))
```

##### After

```swift
// Loop from 0.5 to 1.0
LottieView(animation: myAnimation)
  .playing(.fromProgress(0.5, toProgress: 1.0, loopMode: .loop))

// Pause at the halfway point of the animation
LottieView(animation: myAnimation)
  .paused(at: .progress(0.5))
```

#### New Features in Lottie 4.3.0

-   Add SwiftUI `LottieView`, which wraps UIKit `LottieAnimationView`
- Add SwiftUI `LottieSwitch`, which wraps UIKit `AnimatedSwitch`
([airbnb/lottie-ios#2138)
- Add SwiftUI `LottieButton`, which wraps `AnimatedButton`
([airbnb/lottie-ios#2139)
- `AnimatedSwitch` and `AnimatedButton` now support macOS
([airbnb/lottie-ios#2138,
[airbnb/lottie-ios#2139)
- Add `LottieAnimationLayer`, a Core Animation `CALayer` subclass for
playing Lottie animations
([airbnb/lottie-ios#2073)
- Add support for rendering drop shadow layer effects
([airbnb/lottie-ios#2142)
- Add API for playing multiple markers sequentially
([airbnb/lottie-ios#2084)
- Play "reduced motion" marker if
`UIAccessibility.isReduceMotionEnabled` is true
([airbnb/lottie-ios#2110)
- Update text provider API to use full `AnimationKeypath` values
([airbnb/lottie-ios#2183)
- Add support for visionOS
([airbnb/lottie-ios#2152)
- Drop support for Swift 5.5
([airbnb/lottie-ios#2152)
- Add contents gravity configuration to `AnimationImageProvider`
([airbnb/lottie-ios#2177)
- Add support for customizing stroke width values using
`FloatValueProvider`
([airbnb/lottie-ios#2179)
- Adopt `Sendable` to support using Lottie with strict concurrency
enabled
([airbnb/lottie-ios#2126)
- Add `LottiePlaybackMode` to support declarative playback configuration
([airbnb/lottie-ios#2128)
- Add option make main thread rendering engine force display update on
every frame
([airbnb/lottie-ios#2168)
- Add a option to prevent caching images from `AnimationImageProvider`
([airbnb/lottie-ios#2171)
- Add support for customizing gradient values using
`GradientValueProvider`
([airbnb/lottie-ios#2182)
- Added additional support for multiple animations in `DotLottieFile`
([airbnb/lottie-ios#2074)
- Add helper method to initialize `DotLottieFile` with data
([airbnb/lottie-ios#2090)

#### Bug fixes

- Remove `.../ZipFoundation/README.md` from targets and `*.md*` files
from podspec
([airbnb/lottie-ios#2057
- Fix issue where layers with negative X scale values could be pixelated
([airbnb/lottie-ios#2067)
- Fix warnings when building with Swift 5.9
([airbnb/lottie-ios#2072)
- Restructure `ValueProviderStore` to not accumulate multiple values for
the same key
([airbnb/lottie-ios#2082)
- Disable bitcode when building XCFramework
([airbnb/lottie-ios#2121)
- Fix unhandled file warning when building with SPM
([airbnb/lottie-ios#213)
- Fix support for customizing color of `SolidLayer` using
`ColorValueProvider`
([airbnb/lottie-ios#2154)
- Fix issue where shape items could be unexpectedly ignored
([airbnb/lottie-ios#2156)
- Fix issue where skew keyframes would unexpectedly not animate
([airbnb/lottie-ios#2157)
- Fix issue where value providers could be ignored when falling back to
main thread rendering engine
([airbnb/lottie-ios#2164)

Thanks to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Sep 30, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.3.2"` -> `from: "4.3.3"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.3.3`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.3)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.2...4.3.3)

**Lottie 4.3.0** adds many new features, including:

-   Official support for SwiftUI!
-   A public Core Animation `CALayer` subclass
-   Support for reduced motion
-   Support for drop shadow layer effects
-   Support for visionOS

You can learn more about Lottie 4.3.0 in this announcement: **[Lottie
4.3.0 now available, with official support for SwiftUI
#&#8203;2189](https://togithub.com/airbnb/lottie-ios/discussions/2189)**

Lottie 4.3.3 fixes a regression introduced by Lottie 4.3.0 where the
contents of a `LottieAnimationView` could crossfade / animate
unexpectedly when updating the current `LottieAnimation` or rendering
engine:
[airbnb/lottie-ios#2200

#### New Features in Lottie 4.3.0

-   Add SwiftUI `LottieView`, which wraps UIKit `LottieAnimationView`
- Add SwiftUI `LottieSwitch`, which wraps UIKit `AnimatedSwitch`
([airbnb/lottie-ios#2138)
- Add SwiftUI `LottieButton`, which wraps `AnimatedButton`
([airbnb/lottie-ios#2139)
- `AnimatedSwitch` and `AnimatedButton` now support macOS
([airbnb/lottie-ios#2138,
[airbnb/lottie-ios#2139)
- Add `LottieAnimationLayer`, a Core Animation `CALayer` subclass for
playing Lottie animations
([airbnb/lottie-ios#2073)
- Add support for rendering drop shadow layer effects
([airbnb/lottie-ios#2142)
- Add API for playing multiple markers sequentially
([airbnb/lottie-ios#2084)
- Play "reduced motion" marker if
`UIAccessibility.isReduceMotionEnabled` is true
([airbnb/lottie-ios#2110)
- Update text provider API to use full `AnimationKeypath` values
([airbnb/lottie-ios#2183)
- Add support for visionOS
([airbnb/lottie-ios#2152)
- Drop support for Swift 5.5
([airbnb/lottie-ios#2152)
- Add contents gravity configuration to `AnimationImageProvider`
([airbnb/lottie-ios#2177)
- Add support for customizing stroke width values using
`FloatValueProvider`
([airbnb/lottie-ios#2179)
- Adopt `Sendable` to support using Lottie with strict concurrency
enabled
([airbnb/lottie-ios#2126)
- Add `LottiePlaybackMode` to support declarative playback configuration
([airbnb/lottie-ios#2128)
- Add option make main thread rendering engine force display update on
every frame
([airbnb/lottie-ios#2168)
- Add a option to prevent caching images from `AnimationImageProvider`
([airbnb/lottie-ios#2171)
- Add support for customizing gradient values using
`GradientValueProvider`
([airbnb/lottie-ios#2182)
- Added additional support for multiple animations in `DotLottieFile`
([airbnb/lottie-ios#2074)
- Add helper method to initialize `DotLottieFile` with data
([airbnb/lottie-ios#2090)

#### Bug fixes

- Remove `.../ZipFoundation/README.md` from targets and `*.md*` files
from podspec
([airbnb/lottie-ios#2057
- Fix issue where layers with negative X scale values could be pixelated
([airbnb/lottie-ios#2067)
- Fix warnings when building with Swift 5.9
([airbnb/lottie-ios#2072)
- Restructure `ValueProviderStore` to not accumulate multiple values for
the same key
([airbnb/lottie-ios#2082)
- Disable bitcode when building XCFramework
([airbnb/lottie-ios#2121)
- Fix unhandled file warning when building with SPM
([airbnb/lottie-ios#213)
- Fix support for customizing color of `SolidLayer` using
`ColorValueProvider`
([airbnb/lottie-ios#2154)
- Fix issue where shape items could be unexpectedly ignored
([airbnb/lottie-ios#2156)
- Fix issue where skew keyframes would unexpectedly not animate
([airbnb/lottie-ios#2157)
- Fix issue where value providers could be ignored when falling back to
main thread rendering engine
([airbnb/lottie-ios#2164)

Thanks to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
iago849 pushed a commit to atteamapps/lottie-ios that referenced this pull request Feb 8, 2024
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 14.3 build warning when installing via CocoaPods: no rule to process file .../ZipFoundation/README.md
4 participants