Fixed Carthage support for Swift projects #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Renamed Lottie.h? Wouldn't this break the example project? |
|
I'll try to remove that ugly commit. |
Without this import Swift-based projects won't see any public classes from `Lottie` if it was installed with `Carthage`
av0c0der
changed the title
|
@buba447 it's done. I can confirm that Example project builds without any errors. |
Closed
|
Thank you! |
buba447
approved these changes
Feb 6, 2017
NSGolova
pushed a commit
to clario-tech/lottie-ios
that referenced
this pull request
Nov 19, 2020
Fixed Carthage support for Swift projects
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
Fixed Carthage support for Swift projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual master branch builds with Carthage but project (on Swift) can't access
LAAnimationViewandLAAnimationTransitionControllerbecause of umbrella header doesn't import them.