Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Overlay): Prevent Overlay from rendering at 0, 0 #287

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

alecklandgraf
Copy link
Contributor

@alecklandgraf alecklandgraf commented Jan 21, 2020

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

Fixes tooltips from rendering at 0,0.

Motivation and Context

Tooltips are initially rendering at 0,0.

Testing

Updated tests.

Screenshots

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

airbnb-bot commented Jan 22, 2020

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 569.41 KB 569.31 KB 698.51 KB 698.42 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10741,
    "lib": 14132
  },
  "app-shell": {
    "esm": 13239,
    "lib": 20290
  },
  "composer": {
    "esm": 76809,
    "lib": 114284
  },
  "core": {
    "esm": 582977,
    "lib": 715180
  },
  "forms": {
    "esm": 36794,
    "lib": 48813
  },
  "icons": {
    "esm": 148440,
    "lib": 196853
  },
  "layouts": {
    "esm": 15988,
    "lib": 21451
  },
  "metrics": {
    "esm": 5302,
    "lib": 7308
  },
  "test-utils": {
    "esm": 4216,
    "lib": 5826
  }
}

Current

{
  "apollo": {
    "esm": 10741,
    "lib": 14132
  },
  "app-shell": {
    "esm": 13239,
    "lib": 20290
  },
  "composer": {
    "esm": 76809,
    "lib": 114284
  },
  "core": {
    "esm": 583074,
    "lib": 715277
  },
  "forms": {
    "esm": 36794,
    "lib": 48813
  },
  "icons": {
    "esm": 148440,
    "lib": 196853
  },
  "layouts": {
    "esm": 15988,
    "lib": 21451
  },
  "metrics": {
    "esm": 5302,
    "lib": 7308
  },
  "test-utils": {
    "esm": 4216,
    "lib": 5826
  }
}

@alecklandgraf alecklandgraf marked this pull request as ready for review January 22, 2020 00:52
@alecklandgraf
Copy link
Contributor Author

@stefhatcher found a regression when testing in storybook, all better now

image

@alecklandgraf alecklandgraf merged commit bdc65d2 into master Jan 22, 2020
@alecklandgraf alecklandgraf deleted the aleck--fix-overlay-layout-at-0-0 branch January 22, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants