Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing space before stats table #59

Merged
merged 1 commit into from Aug 28, 2018
Merged

Add missing space before stats table #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion todomvrx/README.md
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ This ToDo app follows the [specification](https://github.com/googlesamples/andro

It is 100% feature complete and has significantly fewer lines of code compared to other archtiecture blueprints.
Running `cloc` on `src/main` for MvRx yields:

| Language LOC | **MvRx** | **mvp-kotlin** | **mvvm-live-kotlin** | **mvp** | **mvp-clean** | **mvp-java** |
| ------------- | ----- | --------- | ---------------- | ------- | ------------- | ------------ |
| **Kotlin** | 803| 1541 | 1564 | 0 | 0 | 0 |
Expand All @@ -21,4 +22,4 @@ It then uses [TasksViewModel](https://github.com/airbnb/MvRx/blob/master/todomvr

All task state is shared between Fragments using this ViewModel.

Snackbars for actions like adding a task are handled using [this block of code](https://github.com/airbnb/MvRx/blob/master/todomvrx/src/main/java/com/airbnb/mvrx/todomvrx/core/BaseFragment.kt#L46) which compares state changes to see when tasks have changed.
Snackbars for actions like adding a task are handled using [this block of code](https://github.com/airbnb/MvRx/blob/master/todomvrx/src/main/java/com/airbnb/mvrx/todomvrx/core/BaseFragment.kt#L46) which compares state changes to see when tasks have changed.